[Dirvish] patch for dirvish, long backups would overlap

John Altstadt john.altstadt at gmail.com
Wed Jan 5 09:15:26 UTC 2011


Thanks Eric, but I will leave that for someone with better perl-foo skills
than me. Perhaps it can be cleaned up for an official patch.

On Tue, Jan 4, 2011 at 2:42 AM, Eric Searcy <emsearcy at gmail.com> wrote:

> On Jan 2, 2011, at 2:13 PM, John Altstadt wrote:
>
> [...]
> >
> > +     if (! -f $lock_file)
> > +     {
> > +         open(LOCK, "+>", $lock_file) or seppuku 150, "cannot create
> $lock_file";
> > +
> [...]
> >
> > I felt it was about time I contributed something back to the community
> again. Please feel free to use this patch or criticize it as you see fit. It
> works for me.
>
> Good idea.  And for a suggestion: you should use a exclusive file lock
> (non-blocking to get the same behavior where you don't wait) to avoid the
> race condition that exists in the above code.
>
> http://perldoc.perl.org/perlopentut.html#File-Locking
>
> Eric
> _______________________________________________
> Dirvish mailing list
> Dirvish at dirvish.org
> http://www.dirvish.org/mailman/listinfo/dirvish
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.dirvish.org/pipermail/dirvish/attachments/20110105/0fa99fbf/attachment.html 


More information about the Dirvish mailing list